Opened on 11/16/2016 at 01:05:10 PM

Closed on 05/12/2017 at 01:36:10 PM

Last modified on 05/15/2017 at 10:47:08 AM

#4648 closed change (fixed)

[ABP for Samsung Internet] - Update source string

Reported by: Shikitita Assignee: diegocarloslima
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: lisabielik, diegocarloslima, vickyyu, mario Blocked By:
Blocking: #4505 Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):



A string currently used for ABP for Samsung Internet needs changing in order to keep consistency across platforms

What to change

"Allow some nonintrusive ads"

should be changed to

"Allow some nonintrusive advertising"

Attachments (0)

Change History (9)

comment:1 Changed on 12/01/2016 at 02:46:03 PM by diegocarloslima

  • Owner set to diegocarloslima
  • Ready set

comment:2 Changed on 12/16/2016 at 10:44:07 AM by diegocarloslima

  • Blocking 4505 added

comment:3 Changed on 01/03/2017 at 06:09:06 PM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 01/04/2017 at 03:04:20 PM by abpbot

A commit referencing this issue has landed:
Issue 4648 - [ABP for Samsung Internet - Update source string]

comment:5 Changed on 01/04/2017 at 03:06:26 PM by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 05/10/2017 at 10:06:31 AM by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer
  • On the first run screen, the wording remains as 'You can change this setting at any time by tapping the Allow some nonintrusive ads option' instead of nonintrusive advertising.

Galaxy S7
Android 7.0
Samsung Internet 5.0+

Galaxy S5
Android 5.0.1
Samsung Internet 4.0

comment:7 Changed on 05/10/2017 at 02:38:13 PM by diegocarloslima

@scheer, the aforementioned issue will be fixed on #5215

comment:8 Changed on 05/12/2017 at 01:36:10 PM by jwangenheim

  • Resolution set to fixed
  • Status changed from reopened to closed

As #5215 was fixed for version 1.1.0, this ticket can be closed.

comment:9 Changed on 05/15/2017 at 10:47:08 AM by scheer

  • Verified working set
  • On the first run screen, the correct wording "Allow some nonintrusive advertising" is used.

Galaxy S4
Android 5.0.1

Galaxy S7
Android 7.0

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Note: See TracTickets for help on using tickets.