Changes between Initial Version and Version 1 of Ticket #4653, comment 6


Ignore:
Timestamp:
11/23/2016 05:21:21 PM (3 years ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4653, comment 6

    initial v1  
    11I am not familiar with this code, but after having a quick look I've found the/a problem. 
    22 
    3 `sitescripts.extensions.utils.getDownloads` calls the `readMetadata` function with no arguments. That function defaults to the "tip" revision and so it will try to read `metadata.safari` for the "tip" revision. That no longer exists, which explains why the problem started happening since November 17th as that was the day that [https://hg.adblockplus.org/adblockpluschrome/rev/3b93e445ab00 the commit to remove that file] landed. 
     3`sitescripts.extensions.utils.getDownloads` calls the `readMetadata` function with no arguments. That function defaults to the "tip" revision and so it will try to read the `metadata.safari` file for the "tip" revision. That no longer exists, which explains why the problem started happening since November 17th as that was the day that [https://hg.adblockplus.org/adblockpluschrome/rev/3b93e445ab00 the commit to remove that file] landed. 
    44 
    55If I'm right - and I didn't test that I am - then I think this should fix it: