Opened 2 years ago

Closed 13 months ago

Last modified 12 months ago

#4655 closed defect (fixed)

Removing an installed search engine replaces it with a new search option

Reported by: passbrains Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29529787/

Description (last modified by diegocarloslima)

Due to a change introduced in #3128 , the Search preference only shows up to 5 Installed search engines, even if more than that are installed.

Given that, removing a search engine, going back to the Settings and then back into the Search pane shows new search engines previously not shown.

This appears quite odd to me, as in one of the cases Twitter was shown as a possible search engine option when re-entering the Search section.

Environment

Asus + Nexus 7 + Android 5.1
Galaxy S5 + Android 5.0.1

How to reproduce

  1. Load ABB Android and tap the Menu button
  2. Tap Settings
  3. Tap Search
  4. Select the Google search option (or any other search engine)
  5. Tap Remove
  6. See Google is removed from the list
  7. Tap Back button
  8. Tap Search option again
  9. Observe Search engines list

Observed behaviour

Removing a search engine, then navigating back and then back into the Search pane, a new Search Engine is shown, that was not previously available.

Expected behaviour

All search engine options should be visible when in the Search options Pane.

Attachments (4)

2609_1478023082_Screenshot_2016-11-01-19-56-42.png (80.0 KB) - added by passbrains 2 years ago.
2609_1478023082_Screenshot_2016-11-01-19-56-47.png (75.9 KB) - added by passbrains 2 years ago.
2609_1478023082_Screenshot_2016-11-01-19-56-54.png (76.8 KB) - added by passbrains 2 years ago.
2609_1478023082_M2U02115_x264.mp4 (1.8 MB) - added by passbrains 2 years ago.

Download all attachments as: .zip

Change History (14)

Changed 2 years ago by passbrains

comment:1 Changed 2 years ago by passbrains

1 - 21 Nov 2016 10:38:08 posted by Scott Cheer
Reproduced ABB Android 1.1.1 (Play Store)
Galaxy S5
Android 5.0.1

comment:2 Changed 2 years ago by scheer

  • Component changed from Unknown to Adblock-Browser-for-Android
  • Description modified (diff)
  • Summary changed from When remove one of the Search engines, it automatically installs new one to Removing an installed search engine replaces it with a new search option

comment:3 Changed 14 months ago by diegocarloslima

  • Priority changed from Unknown to P3

comment:4 Changed 14 months ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Owner set to diegocarloslima
  • Ready set

comment:5 Changed 14 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 13 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 13 months ago by diegocarloslima

  • Description modified (diff)

comment:9 Changed 13 months ago by diegocarloslima

  • Description modified (diff)

comment:10 Changed 12 months ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.