Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4657 closed change (fixed)

Add Acceptable Ads API into FilterEngine

Reported by: sergz Assignee:
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd, oleksandr, asmirnov Blocked By:
Blocking: #5121 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29366747/

Description

Background

It origins from #4612.

Currently the user of libadblockplus has to manually manage AA subscription which is a bit inconvenient and requires to read setting subscriptions_exceptionsurl. It would be better to provide with such managing API.

What to change

  • add the following methods
    • FilterEngine::SetAAEnabled(bool)
    • FilterEngine::IsAAEnabled()
    • Subscription::IsAA() it should allow to find AA subscription among items returned by FilterEngine::GetListedSubscriptions
    • FilterEngine::GetAAURL() it seems not an ideal way but already better than to ask user of libadblockplus to read hard-coded property subscriptions_exceptionsurl. Allows to get AA URL when AA is not enabled and is absent locally.
  • update Readme file

Change History (5)

comment:1 Changed 3 years ago by eric@…

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by asmirnov

  • Cc asmirnov added

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4657 - Add Acceptable Ads API

comment:4 Changed 3 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by asmirnov

  • Blocking 5121 added
Note: See TracTickets for help on using tickets.