Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#4658 closed change (fixed)

Incorporate element hiding emulation filters

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Plus-2.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, kzar Blocked By: #4394, #4592
Blocking: #4659 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29364102/

Description (last modified by fhd)

Background

#4394 replaces CSS property filters with the more generic element hiding emulation filters, #4592 adapts the adblockplusui repository for that. Once these changes have landed, we can update ABP for Firefox to work with the new filter class.

This dependency update is also pulling in #4684, which makes { and } work in property selectors.

What to change

  1. Update the adblockpluscore dependency to revision b1e70036624f and the adblockplusui dependency to revision 4286b54830e5.
  2. Adapt the ABP for Firefox code to work with the new filter class.

Change History (9)

comment:1 Changed 3 years ago by fhd

  • Blocking 4659 added

comment:2 Changed 3 years ago by fhd

  • Summary changed from Adapt for element hiding emulation filters to Incorporate element hiding emulation filters

comment:3 Changed 3 years ago by fhd

  • Blocking 3143 removed

comment:4 Changed 3 years ago by fhd

  • Description modified (diff)

comment:5 Changed 3 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 3 years ago by fhd

  • Description modified (diff)

comment:7 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4658 - Incorporate element hiding emulation filters

comment:8 Changed 3 years ago by fhd

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done/implemented. Appears to work okay (CSS property filters are working).

The only issue I noticed is that hit counters for these filters are not updated: #5256.

ABP 2.8.2.4246-beta
Firefox 51 / 53 / Beta (54.0b2)
Windows 7

Note: See TracTickets for help on using tickets.