Opened 3 years ago

Closed 3 years ago

#4659 closed change (fixed)

Incorporate element hiding emulation filters

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Plus-1.13-for-Chrome-Opera
Module: Platform Keywords:
Cc: kzar Blocked By: #4394, #4592, #4658
Blocking: #4715 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29367475/

Description (last modified by fhd)

Background

#4394 replaces CSS property filters with the more generic element hiding emulation filters, #4592 adapts the adblockplusui repository and #4658 the adblockplus repository.

This dependency update is also pulling in the following changes:

  • #4684, which makes { and } work in property selectors
  • #4644, which adds request filtering to our devtools panel (still needs a platform change though)

What to change

  1. Update the adblockpluscore dependency to revision b1e70036624f, the adblockplusui dependency to revision 7fe282d20303 and the adblockplus dependency to revision c8ec667756d3.
  2. Adapt the platform code to work with the new filter class.

Change History (12)

comment:1 Changed 3 years ago by fhd

  • Summary changed from Adapt for element hiding emulation filters to Incorporate element hiding emulation filters

comment:2 Changed 3 years ago by fhd

  • Blocked By 4394 added

comment:3 Changed 3 years ago by fhd

  • Blocked By 4592 added

comment:4 Changed 3 years ago by fhd

  • Description modified (diff)

comment:5 Changed 3 years ago by wspee

  • Blocking 4715 added

comment:6 Changed 3 years ago by fhd

  • Description modified (diff)

comment:7 Changed 3 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 3 years ago by fhd

  • Description modified (diff)

comment:9 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4659 - Incorporate element hiding emulation filters

comment:10 Changed 3 years ago by fhd

  • Description modified (diff)

comment:11 Changed 3 years ago by fhd

  • Description modified (diff)

comment:12 Changed 3 years ago by fhd

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.