Opened 6 years ago

Closed 5 years ago

#466 closed change (fixed)

[ABP for IE] Replace "ChinaList" with "EasyList China"

Reported by: philll Assignee: oleksandr
Priority: P2 Milestone: Adblock-Plus-1.2-for-Internet-Explorer
Module: Adblock-Plus-for-Internet-Explorer Keywords: ie_devbuild_1.2
Cc: trev, oleksandr, smultron45@… Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6277063212269568/

Description

Background

See #204. We fixed this for all current environments except Internet Explorer.

What to change

In the default filter lists offered in the options page dropdown of ABP for IE, change the list entry label "ChinaList" to "EasyList China"

Change History (12)

comment:1 Changed 6 years ago by trev

  • Cc trev oleksandr added

Oleksandr, could you look into this? You need to update the dependency on libadblockplus repository.

comment:2 Changed 6 years ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 6 years ago by mapx

the home page (in the review) is still wrong
it should be http://abpchina.org/forum/
and not http://chinalist.github.io/

Last edited 6 years ago by mapx (previous) (diff)

comment:4 Changed 6 years ago by mapx

  • Cc smultron45@… added

comment:5 Changed 6 years ago by oleksandr

Changed the homepage as well now

comment:6 Changed 6 years ago by mapx

well, also the title and author...like here:

https://adblockplus.org/en/subscriptions/

EasyList China

supplement for EasyList by John, Li, Jiefei
Homepage, Changelog
Subscribe: EasyList China+EasyList, EasyList China

comment:7 Changed 6 years ago by trev

Oleksandr, please don't change subscriptions.xml manually - that's an autogenerated file. That file has been updated in the adblockplus repository already, all you need to do is linking against the current state of libadblockplus.

comment:8 Changed 6 years ago by oleksandr

  • Owner set to oleksandr

comment:9 Changed 6 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-next

comment:10 Changed 5 years ago by philll

  • Keywords ie_devbuild_1.2 added

comment:11 Changed 5 years ago by oleksandr

adblockplus in libadblockplus was updated in https://hg.adblockplus.org/libadblockplus/changeset/042e60eb83a8

comment:12 Changed 5 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.