Changes between Version 5 and Version 11 of Ticket #4661


Ignore:
Timestamp:
12/06/2016 01:14:10 PM (3 years ago)
Author:
mario
Comment:

Changed the description to reflect the discussed changes and added the new mockups. @jeen, @pavelz, LGTM?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4661

    • Property Cc jeen added
  • Ticket #4661 – Description

    v5 v11  
    44=== What to change === 
    55'''1. Remove limitation''' 
    6  - Make the settings item "Configure Filter List" as shown in [https://issues.adblockplus.org/attachment/ticket/4661/Configure%200.png this screenshot] and its settings page available throughout all builds (not only development builds) 
     6 - Make the settings item "Configure Filter List" as shown in [https://issues.adblockplus.org/attachment/ticket/4661/Configure%201.0.png this screenshot] and its settings page available throughout all builds (not only development builds) 
    77 
    88'''2. Amend UI''' 
    9 Within "ABP -> Settings -> Configure Filter List" apply the following changes as shown in [https://issues.adblockplus.org/attachment/ticket/4661/Configure%201.png this screenshot]: 
    10  - Add a Headline above the "Default Filter List" list item reading {{{The default filter list is based on EasyList}}} 
    11  - Change the Headline {{{OTHER FILTER LISTS}}} to {{{CHANGE THE ACTIVE FILTER LIST}}} 
    12  - Remove the switch control from the list item "Default Filter List" and remove the click event 
    13  - Remove the switch control from the list item "Custom Filter List" and remove the click event 
     9Within "ABP -> Settings" 
     10 - Change the button {{{Configure Filter Lists}}} to {{{Filter Lists}}} 
     11 - Add a iOS default right arrow to the "Filter Lists" button 
     12 - If the default filter list is used, display {{{Default}}} as secondary text of the "Filter Lists" button 
     13 - If a custom filter list is used, display {{{Custom}}} as secondary text of the "Filter Lists" button 
     14 
     15Within "ABP -> Settings -> Configure Filter List" apply the following changes as shown in [https://issues.adblockplus.org/attachment/ticket/4661/Configure%201b.png this screenshot]: 
     16 - Remove the control "Default Filter List" 
     17 - Change the Headline {{{OTHER FILTER LISTS}}} to {{{The default filter list used is based on EasyList. You can specify a different iOS content blocking filter list to use below}}} 
     18 - Change the label {{{Custom Filter List}}} to {{{Use Custom Filter List}}} 
    1419 - Add {{{Filter List}}} label in front of the custom filter list input field 
    15  - Change the label of the button {{{Update Filter Lists}}} to {{{Update Filter List}}} 
    16  - Add a new list item above "Custom Filter List" called {{{Switch Filter List}}} containing a switch control 
    17 Any other UI as derived from #3241 stays in place 
     20 - Change the label of the button {{{Update Filter Lists}}} to {{{Update filter list}}} 
    1821 
    1922'''3. Amend logic''' 
    20  - "Switch Filter List" is turned off by default 
    21  - If "Switch Filter List" is turned off (as shown in [https://issues.adblockplus.org/attachment/ticket/4661/Configure%201.png this screenshot]) 
    22   - Hide the "Custom Filter List" list item 
     23 - "Use Custom Filter List" is turned off by default 
     24 - If "Use Custom Filter List" is turned off (as shown in [https://issues.adblockplus.org/attachment/ticket/4661/Configure%201a.2.png this screenshot]) 
    2325  - Hide the "Filter List" input field 
    24   - Display a check mark in the list item "Default Filter List" 
    25   - Style "Default Filter List" as active 
    26  - If "Switch Filter List" is turned on (as shown in [https://issues.adblockplus.org/attachment/ticket/4661/Configure%202.png this screenshot]) 
    27   - Show the "Custom Filter List" list item 
     26  - Hide the "Update filter list" button 
     27 - If "Switch Filter List" is turned on (as shown in [https://issues.adblockplus.org/attachment/ticket/4661/Configure%201b.png this screenshot]) 
    2828  - Show the "Filter List" input field 
    29   - Remove the check mark in the list item "Default Filter List" 
    30   - Display a check mark in the list item "Custom Filter List" 
    31   - Style "Default Filter List" as inactive 
     29  - Show the "Update filter list" button 
    3230Any other logic as derived from #3241 stays in place