Opened 3 years ago

Closed 2 years ago

#4666 closed change (rejected)

EHH: replace keyCode deprecated property

Reported by: saroyanm Assignee:
Priority: P4 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

We do use KeyboardEvent object's keyCode property to determine the pressed key, but while the property is deprecated we need to replace it with more stable solution.

What to change

Replace deprecated keyCode property with non deprecated one, ex.: KeyboardEvent.code

Change History (4)

comment:1 Changed 3 years ago by saroyanm

I'm not really sure ​KeyboardEvent.code is supported in Seamonkey and Thunderbird, it may appear that we will need a polyfill I guess.

comment:2 Changed 3 years ago by trev

  • Priority changed from Unknown to P4
  • Ready set

Yes, SeaMonkey and Thunderbird are also based on Gecko - we currently require at least Gecko 38 so all of them support KeyboardEvent.code.

comment:3 Changed 3 years ago by trev

  • Cc trev added

comment:4 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.

Note: See TracTickets for help on using tickets.