Opened on 11/25/2016 at 04:12:39 PM

Closed on 11/10/2017 at 11:17:30 AM

#4666 closed change (rejected)

EHH: replace keyCode deprecated property

Reported by: saroyanm Assignee:
Priority: P4 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



We do use KeyboardEvent object's keyCode property to determine the pressed key, but while the property is deprecated we need to replace it with more stable solution.

What to change

Replace deprecated keyCode property with non deprecated one, ex.: KeyboardEvent.code

Attachments (0)

Change History (4)

comment:1 Changed on 11/25/2016 at 04:16:17 PM by saroyanm

I'm not really sure ​KeyboardEvent.code is supported in Seamonkey and Thunderbird, it may appear that we will need a polyfill I guess.

comment:2 Changed on 12/01/2016 at 09:22:57 AM by trev

  • Priority changed from Unknown to P4
  • Ready set

Yes, SeaMonkey and Thunderbird are also based on Gecko - we currently require at least Gecko 38 so all of them support KeyboardEvent.code.

comment:3 Changed on 12/01/2016 at 09:23:15 AM by trev

  • Cc trev added

comment:4 Changed on 11/10/2017 at 11:17:30 AM by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.