Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#4669 closed change (fixed)

Mention $popup filter option on filters documentation page

Reported by: arthur Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: saroyanm, lisabielik, vickyyu, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29500682

Description (last modified by arthur)

Background

The $popup filter option is missing on the filters documentation page.

What to change

Pop-up blocking support was added to Adblock Plus for Firefox in 2011 (see announcement). It seems it was forgotten to update the filters documentation back then. It should be mentioned in the filter options as well.

Draft

$popup - pages opened in a new tab or window

Attachments (1)

filters.html (26.6 KB) - added by juliandoucette 3 years ago.
Filters page 161205 pre #4669

Download all attachments as: .zip

Change History (21)

comment:1 Changed 3 years ago by arthur

  • Cc vickyyu added

comment:2 Changed 3 years ago by juliandoucette

@arthur can you draft the text of this update? I'm guessing you know the technical details better than @lisabielik?

comment:3 Changed 3 years ago by juliandoucette

  • Priority changed from Unknown to P5

comment:4 Changed 3 years ago by arthur

  • Description modified (diff)

@julian

Sure, done.

comment:5 Changed 3 years ago by juliandoucette

  • Priority changed from P5 to Unknown

Changed 3 years ago by juliandoucette

Filters page 161205 pre #4669

comment:6 Changed 3 years ago by juliandoucette

@arthur

  • Where does the draft text go?
  • Is that all that is required to properly document this feature?

comment:7 Changed 3 years ago by lisabielik

@arthur, @juliandoucette:

Should we just update all of the text on the page? There are some things that need to be fixed.

comment:8 Changed 3 years ago by arthur

@lisa
What is it exactly? Do we have filed bugs for that?

@julian
I would suggest below the genericblock option explanation. I would say so but it wouldn't hurt if Wladimir could have a quick look I think.

comment:9 Changed 3 years ago by lisabielik

@arthur:

I worked on this page way back when I first started but never created a ticket or got my changes updated. I *think* @jeen is having Felix review this content to assure that it is still accurate before we start the text rewrite for ABP.org. Since this is a lot to work with, I suggest we just make your proposed change and wait to update the rest of the page when we start the new ABP.org content. So nevermind my question and sorry for the confusion!

Also, where is the text change at in the file filters.html? Sorry, but I'm not seeing it?

comment:10 Changed 3 years ago by arthur

@lisabielik
I think the filters.html represents the current state. Since Wladimir is on holidays I'll ask Thomas to have a quick look.

comment:11 Changed 3 years ago by arthur

@juliandoucette
I got feedback from Thomas. He said that should be sufficient.

comment:12 Changed 3 years ago by juliandoucette

  • Cc greiner added
  • Priority changed from Unknown to P3
  • Ready set

@greiner @arthur please let me know if you think this should be a higher priority.

comment:13 Changed 3 years ago by vickyyu

Hi guys, was this ever implemented?

comment:14 Changed 3 years ago by arthur

@julian
It would be great if this could be added asap. Thanks!

comment:15 Changed 2 years ago by ire

  • Owner set to ire

comment:16 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:17 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4669 - Mention filter option on filters documentation page

comment:18 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:19 Changed 2 years ago by arthur

Now that I see it on the page, the $ character shouldn't actually be part of it. Could someone remove it?

Note: See TracTickets for help on using tickets.