#4676 closed change (fixed)

Replace non-standard CSSStyleSheet.addRule() call by CSSStyleSheet.insertRule()

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-1.13-for-Chrome-Opera
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29365801/

Description

Background

include.preload.js calls CSSStyleSheet.addRule() in order to add a style rule. This is a non-standard method introduced in Internet Explorer and apparently implemented in Chrome for compatibility reasons. Firefox doesn't support it.

What to change

Call the standard CSSStyleSheet.insertRule() method.

Change History (4)

comment:1 Changed 12 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 12 months ago by kzar

  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 12 months ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.