Opened 3 years ago

Closed 2 years ago

#4677 closed change (fixed)

Add support for x86 builds in adblockbrowser-build

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By: #4566, #4567
Blocking: #2791, #3768, #4679 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29365816/

Description (last modified by diegocarloslima)

Background

Currently, our build script in adblockbrowser-build is only able to generate APKs for ARM architecture.

What to change

Add support for generating x86 builds with all current variations for distribution and build modes through a configuration change in the config.py file

Hints for Testers

The ARCHITECTURE configuration was added in the configure.py.sample file. If its set to ARCHITECTURE = "arm", it should produce an .apk that runs on ARM devices. If its set to ARCHITECTURE = "x86", it should produce an .apk that runs on x86 devices.

Change History (10)

comment:1 Changed 3 years ago by diegocarloslima

  • Blocked By 4566, 4567 added

comment:2 Changed 3 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by diegocarloslima

  • Blocking 4679 added

comment:4 Changed 3 years ago by diegocarloslima

  • Blocking 3768 added

comment:5 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4677 - Add support for x86 builds in adblockbrowser-build

comment:6 Changed 3 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 2 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened

Does this mean we can now produce two builds, one with the ability to run on other architectures, or that both architectures should function from the one same build? Could we have hints for testers here?

comment:8 Changed 2 years ago by diegocarloslima

This means that we can now produce 2 different apks, one that runs on arm devices and one that runs on x86 devices. I'll update the description

comment:9 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:10 Changed 2 years ago by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Tester changed from Unknown to Scheer
  • Verified working set

adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0

Note: See TracTickets for help on using tickets.