Opened on 11/30/2016 at 01:46:47 PM

Closed on 07/05/2017 at 08:54:05 AM

#4677 closed change (fixed)

Add support for x86 builds in adblockbrowser-build

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By: #4566, #4567
Blocking: #2791, #3768, #4679 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by diegocarloslima)


Currently, our build script in adblockbrowser-build is only able to generate APKs for ARM architecture.

What to change

Add support for generating x86 builds with all current variations for distribution and build modes through a configuration change in the file

Hints for Testers

The ARCHITECTURE configuration was added in the file. If its set to ARCHITECTURE = "arm", it should produce an .apk that runs on ARM devices. If its set to ARCHITECTURE = "x86", it should produce an .apk that runs on x86 devices.

Attachments (0)

Change History (10)

comment:1 Changed on 11/30/2016 at 01:54:52 PM by diegocarloslima

  • Blocked By 4566, 4567 added

comment:2 Changed on 11/30/2016 at 04:50:20 PM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 11/30/2016 at 05:33:10 PM by diegocarloslima

  • Blocking 4679 added

comment:4 Changed on 12/28/2016 at 06:24:19 PM by diegocarloslima

  • Blocking 3768 added

comment:5 Changed on 12/28/2016 at 06:31:22 PM by abpbot

A commit referencing this issue has landed:
Issue 4677 - Add support for x86 builds in adblockbrowser-build

comment:6 Changed on 12/28/2016 at 06:32:15 PM by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 06/21/2017 at 08:28:29 AM by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened

Does this mean we can now produce two builds, one with the ability to run on other architectures, or that both architectures should function from the one same build? Could we have hints for testers here?

comment:8 Changed on 06/30/2017 at 08:11:56 PM by diegocarloslima

This means that we can now produce 2 different apks, one that runs on arm devices and one that runs on x86 devices. I'll update the description

comment:9 Changed on 06/30/2017 at 08:16:27 PM by diegocarloslima

  • Description modified (diff)

comment:10 Changed on 07/05/2017 at 08:54:05 AM by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Tester changed from Unknown to Scheer
  • Verified working set

Galaxy S7
Android 7.0

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Note: See TracTickets for help on using tickets.