Opened on 11/30/2016 at 04:12:30 PM

Closed on 09/22/2017 at 08:44:16 PM

#4678 closed change (rejected)

Implement JSHydra monkey-patch for Safari builds

Reported by: kzar Assignee:
Priority: P5 Milestone:
Module: Platform Keywords:
Cc: trev, sebastian Blocked By: #4552
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Now that we have removed JSHydra from buildtools (#4552) we will need to add it back for Safari builds if we ever want to update the buildtools dependency there again.

What to change

Stolen from the description of #4552:

Our Safari branch should then add a direct dependency on JSHydra and monkey-patch packagerChrome.convertJS in order to transpile the code (probably best to do that after the merging code has executed and remove merging functionality from JSHydra).

Attachments (0)

Change History (2)

comment:1 Changed on 11/30/2016 at 04:13:33 PM by kzar

  • Platform changed from Unknown / Cross platform to Safari

(Given P5 for now. If we ever actually need to update buildtools for Safari builds this issue will be a blocker and can have a higher priority.)

comment:2 Changed on 09/22/2017 at 08:44:16 PM by sebastian

  • Resolution set to rejected
  • Status changed from new to closed

This is no longer relevant, as with #5752, we remove support for Safari builds completely. Hence, the safari branch has to remain using an old version of buildtools, anyway.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.