Opened 3 years ago

Closed 3 years ago

#4679 closed change (fixed)

Refactoring of build.py in adblockbrowser-build

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P5 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By: #4677
Blocking: #3768 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

There are some opportunities of refactoring in build.py, such as replacing multiple instances of the same hardcoded string, line size adjustment to be in conformity of PEP8, changing variable and function names to indicate internal use only. Also, the config.py error messages should be improved to indicate which are the available set of values for each available configuration.

What to change

Perform refactoring on build.py code accordingly to best practices and also improve build configuration error messages

Change History (3)

comment:1 Changed 3 years ago by diegocarloslima

  • Blocking 3768 added

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4679 - Refactoring of build.py in adblockbrowser-build

comment:3 Changed 3 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.