Opened on 11/30/2016 at 05:33:10 PM

Closed on 12/28/2016 at 06:50:51 PM

#4679 closed change (fixed)

Refactoring of in adblockbrowser-build

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P5 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By: #4677
Blocking: #3768 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



There are some opportunities of refactoring in, such as replacing multiple instances of the same hardcoded string, line size adjustment to be in conformity of PEP8, changing variable and function names to indicate internal use only. Also, the error messages should be improved to indicate which are the available set of values for each available configuration.

What to change

Perform refactoring on code accordingly to best practices and also improve build configuration error messages

Attachments (0)

Change History (3)

comment:1 Changed on 12/28/2016 at 06:24:19 PM by diegocarloslima

  • Blocking 3768 added

comment:2 Changed on 12/28/2016 at 06:47:40 PM by abpbot

A commit referencing this issue has landed:
Issue 4679 - Refactoring of in adblockbrowser-build

comment:3 Changed on 12/28/2016 at 06:50:51 PM by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Note: See TracTickets for help on using tickets.