Opened 4 years ago

Last modified 3 years ago

#4684 closed defect

Element hiding filters containing { or } in the selector part do not work — at Initial Version

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Core Keywords:
Cc: trev, scuturic, amrmak, arthur Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29367031/

Description

Environment

ABP for Firefox 2.8.2

How to reproduce

  1. Go to filter preferences.
  2. Add a custom element hiding filter containing { or }, e.g.: `example.com##[-abp-properties="/margin: [0-9]{2}px/"]

Observed behaviour

All spaces are being removed from the filter (as a side effect of it not being detected as an element hiding filter) and it doesn't actually work (since it fails the validity check).

Expected behaviour

The filter shows up in the list just as it was typed in, and it actually works.

Change History (0)

Note: See TracTickets for help on using tickets.