Opened 3 years ago

Closed 3 years ago

#4685 closed change (fixed)

Update images on eyeo.com

Reported by: saroyanm Assignee: erick
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: Marsha, jeen, christiane, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29369432/

Description (last modified by saroyanm)

Background

Currently images on eyeo.com are outdated.

What to change

Add/change on pages below:

Change favicon:

Attachments (18)

eyeo-home-1.jpg (445.6 KB) - added by saroyanm 3 years ago.
Main image
hr-1.JPG (170.3 KB) - added by saroyanm 3 years ago.
hr-2.jpg (532.9 KB) - added by saroyanm 3 years ago.
hr-3.jpg (287.4 KB) - added by saroyanm 3 years ago.
hr-4.jpg (215.0 KB) - added by saroyanm 3 years ago.
hr-5.jpg (418.2 KB) - added by saroyanm 3 years ago.
hr-6.JPG (507.7 KB) - added by saroyanm 3 years ago.
hr-7.jpg (489.2 KB) - added by saroyanm 3 years ago.
hr-8.jpg (417.2 KB) - added by saroyanm 3 years ago.
eyeo_icon-01.png (8.3 KB) - added by saroyanm 3 years ago.
pr1
eyeo_tillfaida.jpg (256.2 KB) - added by saroyanm 3 years ago.
pr2
eyeo_logo-01.png (11.1 KB) - added by saroyanm 3 years ago.
pr3
AdblockPlus_logo.png (61.5 KB) - added by saroyanm 3 years ago.
opr
AdblockBrowser_logo.png (43.5 KB) - added by saroyanm 3 years ago.
pr5
eyeo_favicon_32.png (440 bytes) - added by saroyanm 3 years ago.
favicon 32px
eyeo_favicon_64.png (882 bytes) - added by saroyanm 3 years ago.
favicon 64px
eyeo-home-1x.png (751.3 KB) - added by juliandoucette 3 years ago.
New homepage banner 1x
eyeo-home-2x.png (2.9 MB) - added by juliandoucette 3 years ago.
New homepage bannner 2x

Download all attachments as: .zip

Change History (40)

Changed 3 years ago by saroyanm

Main image

Changed 3 years ago by saroyanm

Changed 3 years ago by saroyanm

Changed 3 years ago by saroyanm

Changed 3 years ago by saroyanm

Changed 3 years ago by saroyanm

Changed 3 years ago by saroyanm

Changed 3 years ago by saroyanm

Changed 3 years ago by saroyanm

Changed 3 years ago by saroyanm

pr1

Changed 3 years ago by saroyanm

pr2

Changed 3 years ago by saroyanm

pr3

Changed 3 years ago by saroyanm

opr

Changed 3 years ago by saroyanm

pr5

Changed 3 years ago by saroyanm

favicon 32px

Changed 3 years ago by saroyanm

favicon 64px

comment:1 Changed 3 years ago by saroyanm

  • Component changed from Unknown to Websites
  • Description modified (diff)

comment:2 Changed 3 years ago by saroyanm

  • Cc Marsha added

@Marsha, can you please confirm that the PR section looks Okey ?

comment:3 Changed 3 years ago by saroyanm

  • Description modified (diff)

comment:4 Changed 3 years ago by saroyanm

  • Description modified (diff)

comment:5 follow-up: Changed 3 years ago by juliandoucette

  • Cc jeen christiane added

Are these approved by @jeen && @christiane?

comment:6 in reply to: ↑ 5 Changed 3 years ago by saroyanm

Replying to juliandoucette:

Are these approved by @jeen && @christiane?

They was provided by Christiane, so I assume - yes.

HR related section approved by @Maren, PR related waiting for the response from @Marsha, in addition @jeen if you have concerns regarding the images please let me know, I'm waiting for PR feedback to mark this as ready.

comment:7 Changed 3 years ago by saroyanm

  • Priority changed from Unknown to P3
  • Ready set

Just aligned with @Marsha and PR section as described in the ticket is fine.

comment:8 Changed 3 years ago by jeen

I'm fine with the images.

comment:9 Changed 3 years ago by juliandoucette

  • Owner set to juliandoucette
  • Priority changed from P3 to P2

Bumping this to P2 after aligning with Till.

I'll get something into review today.

comment:10 Changed 3 years ago by juliandoucette

  • Owner juliandoucette deleted

comment:11 Changed 3 years ago by erick

  • Owner set to erick

comment:12 Changed 3 years ago by erick

  • Status changed from new to reviewing

comment:13 Changed 3 years ago by erick

  • Review URL(s) modified (diff)

comment:14 Changed 3 years ago by juliandoucette

  • Ready unset

@jeen, @christiane

These images were not sized & optimized properly. I'm on it.

EDIT: It doesn't make sense to combine the images on https://eyeo.com/en/jobs/#why actually (it's not accessible).

Last edited 3 years ago by juliandoucette (previous) (diff)

comment:15 Changed 3 years ago by juliandoucette

@jeen, @christiane

The text in the home page image is blurry.

I don't have the source file. Can you please create a 2x version with crisp text?

Version 0, edited 3 years ago by juliandoucette (next)

Changed 3 years ago by juliandoucette

New homepage banner 1x

Changed 3 years ago by juliandoucette

New homepage bannner 2x

comment:16 Changed 3 years ago by juliandoucette

I've attached the home page images received.

The optimized images can be found in the description of the review.

comment:17 Changed 3 years ago by juliandoucette

  • Ready set

comment:18 Changed 3 years ago by greiner

  • Cc greiner added

Merged #4585 and #4660 into this ticket.

comment:19 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4685 - Updated images to match new brand

comment:20 Changed 3 years ago by Marsha

Last edited 3 years ago by Marsha (previous) (diff)

comment:21 Changed 3 years ago by Marsha

Last edited 3 years ago by Marsha (previous) (diff)

comment:22 Changed 3 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.