Opened 4 years ago

Last modified 4 years ago

#4685 closed change

Update images on eyeo.com — at Version 13

Reported by: saroyanm Assignee: erick
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: Marsha, jeen, christiane, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29369432/

Description (last modified by saroyanm)

Background

Currently images on eyeo.com are outdated.

What to change

Add/change on pages below:

Change favicon:

Change History (29)

Changed 4 years ago by saroyanm

Main image

Changed 4 years ago by saroyanm

Changed 4 years ago by saroyanm

Changed 4 years ago by saroyanm

Changed 4 years ago by saroyanm

Changed 4 years ago by saroyanm

Changed 4 years ago by saroyanm

Changed 4 years ago by saroyanm

Changed 4 years ago by saroyanm

Changed 4 years ago by saroyanm

pr1

Changed 4 years ago by saroyanm

pr2

Changed 4 years ago by saroyanm

pr3

Changed 4 years ago by saroyanm

opr

Changed 4 years ago by saroyanm

pr5

Changed 4 years ago by saroyanm

favicon 32px

Changed 4 years ago by saroyanm

favicon 64px

comment:1 Changed 4 years ago by saroyanm

  • Component changed from Unknown to Websites
  • Description modified (diff)

comment:2 Changed 4 years ago by saroyanm

  • Cc Marsha added

@Marsha, can you please confirm that the PR section looks Okey ?

comment:3 Changed 4 years ago by saroyanm

  • Description modified (diff)

comment:4 Changed 4 years ago by saroyanm

  • Description modified (diff)

comment:5 follow-up: Changed 4 years ago by juliandoucette

  • Cc jeen christiane added

Are these approved by @jeen && @christiane?

comment:6 in reply to: ↑ 5 Changed 4 years ago by saroyanm

Replying to juliandoucette:

Are these approved by @jeen && @christiane?

They was provided by Christiane, so I assume - yes.

HR related section approved by @Maren, PR related waiting for the response from @Marsha, in addition @jeen if you have concerns regarding the images please let me know, I'm waiting for PR feedback to mark this as ready.

comment:7 Changed 4 years ago by saroyanm

  • Priority changed from Unknown to P3
  • Ready set

Just aligned with @Marsha and PR section as described in the ticket is fine.

comment:8 Changed 4 years ago by jeen

I'm fine with the images.

comment:9 Changed 4 years ago by juliandoucette

  • Owner set to juliandoucette
  • Priority changed from P3 to P2

Bumping this to P2 after aligning with Till.

I'll get something into review today.

comment:10 Changed 4 years ago by juliandoucette

  • Owner juliandoucette deleted

comment:11 Changed 4 years ago by erick

  • Owner set to erick

comment:12 Changed 4 years ago by erick

  • Status changed from new to reviewing

comment:13 Changed 4 years ago by erick

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.