Opened 3 years ago

Closed 20 months ago

#4690 closed change (rejected)

Localize action attribute in adblockplus/cms

Reported by: juliandoucette Assignee: jsonesen
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: kvas, jsonesen, philll, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

  • Anchor href is automatically localized if it's value is relative in adblockplus/cms
  • Form action should function the same way

What to change

  • Localize form action attribute automatically if it's value is relative in Markdown and HTML templates in adblockplus/cms

Change History (4)

comment:1 Changed 3 years ago by jsonesen

  • Owner set to jsonesen

comment:2 Changed 3 years ago by jsonesen

Actually after testing this it appears that the link is actually dynamically localized once the action link is resolved.

comment:3 Changed 2 years ago by juliandoucette

I don't know what you mean or how that is relevant.

I'm talking about the action attribute of the form element.

e.g.

<a href="page_name"> becomes <a href="/en/page_name">

but

<form action="page_name"> remains <form action="page_name">

comment:4 Changed 20 months ago by juliandoucette

  • Resolution set to rejected
  • Status changed from new to closed

On second thought, I think that this is a bad idea because we should not assume that form actions are localized by directory.

Note: See TracTickets for help on using tickets.