Changes between Initial Version and Version 1 of Ticket #4694


Ignore:
Timestamp:
12/21/2016 08:25:00 PM (2 years ago)
Author:
eric@…
Comment:

Review https://codereview.adblockplus.org/29369479/ uses std::mutex for synchronization.

Using JsContext would gratuitously convoluted at best. The only synchronization mechanism in JsContext is its member v8::Locker, which only synchronizes v8 engine operations. It would be possible to use v8::Locker by evaluating some JS code (to get into the engine and avail ourselves of its lock) and then calling back out it back to our code. It's much, much easier just to use standard C++ synchronization (with C++11).

Legend:

Unmodified
Added
Removed
Modified