Opened 3 years ago

Closed 3 years ago

Last modified 22 months ago

#4698 closed defect (fixed)

Text not shown in popup window on Edge

Reported by: oleksandr Assignee:
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29366773/

Description (last modified by kzar)

Environment

Adblock Plus for Edge (2be9784cc9ca)
Edge 38.14393.0.0
EdgeHTML 14.14393
Windows 10 Anniversary Update

How to reproduce

  1. Click on the ABP icon.

Observed behaviour

The popup opens but none of the text is displayed. (See the attached screenshot.)

Expected behaviour

The text should be displayed.

Notes

The problem appears to be caused to this bug with the Edge extension APIs. browser.i18n.getMessage does not accept an array of substitutions when called from a content script.

Attachments (1)

abp_popup.png (35.8 KB) - added by oleksandr 3 years ago.

Download all attachments as: .zip

Change History (8)

Changed 3 years ago by oleksandr

comment:1 Changed 3 years ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by kzar

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Summary changed from Popup window is broken in Edge to Text not show in popup window on Edge

Updated the description and title for you. Mind adding Windows and Edge versions so I can mark this as ready?

comment:3 Changed 3 years ago by oleksandr

  • Description modified (diff)

Added the versions, however I think the previous description made more sense. The popup page is not working. It is not merely that the text is not displayed.

comment:4 Changed 3 years ago by kzar

  • Description modified (diff)
  • Summary changed from Text not show in popup window on Edge to Text not shown in popup window on Edge

Well the previous description said that the popup did not render properly and to see the screenshot. I looked at the attached screenshot and the only thing I noticed was broken was the missing text.

If there is something else that was broken with how the popup was rendered then feel free to add that to the description too. (This is why it matters to write clear issue descriptions.)

comment:5 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4698 - Popup window is broken in Edge

comment:6 Changed 3 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 22 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Popup looks to be displaying and working fine now in Edge.

ABP 0.9.11.1849
Edge 40 / Windows 10

Last edited 22 months ago by Ross (previous) (diff)
Note: See TracTickets for help on using tickets.