Opened 12 months ago

Closed 6 weeks ago

#4699 closed defect (fixed)

Edge does not support 16px and 32px icons

Reported by: oleksandr Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords: externaldependency
Cc: kzar, sebastian Blocked By:
Blocking: #5767 Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29366791/
https://codereview.adblockplus.org/29557724/

Description

Using browserAction.setIcon we are currently setting an icon with these sizes: 16px, 19px, 20px, 32px, 38px, 40px. If that fails we only resort to 19px and 38px. However Edge supports 19px, 20px, 38px, 40px, and it throws an exception if passed anything other than those sizes, causing us to use suboptimal icon size. We should support all icon sized of Edge.

Change History (12)

comment:1 Changed 12 months ago by oleksandr

  • Summary changed from Edge does not support 16px and 32px to Edge does not support 16px and 32px icons

comment:2 Changed 12 months ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 12 months ago by kzar

  • Priority changed from Unknown to P4

Please file an issue with the Edge guys about this, they should ignore unused resolutions instead of throwing an exception.

comment:4 Changed 12 months ago by kzar

  • Priority changed from P4 to Unknown
  • Ready unset

Unmarking this as ready since it's not clear how we should proceed yet. (See discussion in the codereview.)

comment:5 Changed 12 months ago by oleksandr

There is a related issue in Edge bug tracker on this here

comment:6 Changed 8 months ago by kzar

  • Cc kzar sebastian added
  • Keywords externaldependency added

According to that issue the Edge team are going to fix this their end, so looks like we can just wait.

comment:7 Changed 2 months ago by Ross

Not sure of the state of this one? The icon used as the browser icon seems to be 40px.

ABP 0.9.11.1849
Edge 40 / Windows 10

comment:8 Changed 2 months ago by sebastian

Microsoft Edge uses icons in 20px (low-res) and 40px (high-res). We provide icons in these dimensions, along icons in other sizes required by other browsers. However, providing the icon as well in these other sizes causes errors on Microsoft Edge. While this can be considered a bug in Microsoft Edge, according to Ollie, it hasn't been fixed on their end yet, so we finally might have to implement a workaround.

comment:9 Changed 8 weeks ago by oleksandr

  • Review URL(s) modified (diff)

comment:10 Changed 8 weeks ago by oleksandr

  • Blocking 5767 added

comment:11 Changed 8 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 4699 - Edge does not support 16px and 32px icons

comment:12 Changed 6 weeks ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.