Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#471 closed defect (fixed)

YouTube video ads aren't blocked on Safari again.

Reported by: sebastian Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.8.2-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: trev, philll Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5096307580469248

Description

Environment

Safari 7

How to reproduce

  1. Go to youtube.com
  2. Click on any video

Observed behaviour

You see prerolls and/or overlay ads.

Expected behaviour

All ads should be blocked.

Change History (4)

comment:1 Changed 6 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Apparently YouTube updated their website again. It isn't sufficient anymore to patch history.pushState to disable the history API. However patching History.prototype.pushState still does the trick.

comment:2 Changed 6 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 6 years ago by philll

  • Verified working set

comment:4 Changed 6 years ago by sebastian

  • Ready set
Note: See TracTickets for help on using tickets.