Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#4712 closed change (fixed)

[adblockbrowser.org] - Remove Hindi and Bengali from the website and all traces of these languages

Reported by: Shikitita Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: saroyanm, sporz, jeen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29500631

Description

Background

Hindi and Bengali aren't part of our top priority languages

What to change

All traces of these two languages should be removed from adblockbrowser.org as well as the possibility of selecting them on the website

Change History (16)

comment:1 Changed 3 years ago by saroyanm

  • Cc saroyanm sporz jeen added

@Stephan can you please provide a statistics about people visiting Bengali and Hindi version of the website ?
I think we need to be sure that the usage is minor so that we are on the safe side of removing the languages completely.

comment:2 follow-up: Changed 2 years ago by juliandoucette

BUMP.

+ @saroyanm wouldn't this be done in crowdin?

comment:3 Changed 2 years ago by jpeterka

@saroyanm 5-10 website visitors a day use the hindi or bengali version of the website. That's 0.02% of daily website visitors.

comment:4 Changed 2 years ago by jeen

Those numbers seem sufficiently low to justify removing both languages from the website.

comment:5 in reply to: ↑ 2 ; follow-up: Changed 2 years ago by saroyanm

Replying to juliandoucette:

BUMP.

+ @saroyanm wouldn't this be done in crowdin?

This need some tests, we specify languages in settings page as well, depending on what is Tamara plan about crowdin strings the removal approach might be diffrent:

  • @Tamara you want to keep the translation in crowdin or remove them from crowdin as well ?

comment:6 in reply to: ↑ 5 Changed 2 years ago by Shikitita

Replying to saroyanm:

Replying to juliandoucette:

BUMP.

+ @saroyanm wouldn't this be done in crowdin?

This need some tests, we specify languages in settings page as well, depending on what is Tamara plan about crowdin strings the removal approach might be diffrent:

  • @Tamara you want to keep the translation in crowdin or remove them from crowdin as well ?

Sorry for my late reply.

It shouldn't be a problem if the translations stay in Crowdin. Just note that any future new texts or sections (e.g.: the text for the Android permissions as per issue #3598), won't be requested for translation into Hindi and Bengali.

comment:7 follow-up: Changed 2 years ago by juliandoucette

Thanks Shikitita.

If I understand correctly, there is no action to be taken to resolve this ticket. I believe that a language is added automatically if there are enough translations in crowdin. Can you please verify saroyanm? (And close this ticket if there is nothing to do.)

comment:8 in reply to: ↑ 7 ; follow-up: Changed 2 years ago by saroyanm

Replying to juliandoucette:

Thanks Shikitita.

If I understand correctly, there is no action to be taken to resolve this ticket. I believe that a language is added automatically if there are enough translations in crowdin. Can you please verify saroyanm? (And close this ticket if there is nothing to do.)

There actually is (if Tamara wants to keep the translations in Crowdin): Tamara's request is about removing the mentioned two languages from the repository, but not from the Crowdin, so we might need to remove all Hindi and Bengali locales and update settings file accordingly (to force script from fetching the translations until Tamara say so, is how I understand).

If Tamara is fine with removing them from Crowdin as well, the only thing she need to do is to remove the mentioned languages from the Crowdin interface. That what I meant to find out in my comment.

Version 0, edited 2 years ago by saroyanm (next)

comment:9 in reply to: ↑ 8 ; follow-up: Changed 2 years ago by saroyanm

Replying to saroyanm:

Replying to juliandoucette:

Thanks Shikitita.

If I understand correctly, there is no action to be taken to resolve this ticket. I believe that a language is added automatically if there are enough translations in crowdin. Can you please verify saroyanm? (And close this ticket if there is nothing to do.)

There actually is (if Tamara wants to keep the translations in Crowdin): Tamara's request is about removing the mentioned two languages from the repository, but not from the Crowdin, so we might need to remove all Hindi and Bengali locales and update settings file accordingly (to prevent script from fetching the translations until Tamara say so, is how I understand).

Tamara is this correct ?

If Tamara is fine with removing them from Crowdin as well, the only thing she need to do is to remove the mentioned languages from the Crowdin interface. That what I meant to find out in my comment.

If the above is not correct, should we proceed with current solution ?

comment:10 in reply to: ↑ 9 Changed 2 years ago by Shikitita

Replying to saroyanm:

Replying to saroyanm:

There actually is (if Tamara wants to keep the translations in Crowdin): Tamara's request is about removing the mentioned two languages from the repository, but not from the Crowdin, so we might need to remove all Hindi and Bengali locales and update settings file accordingly (to prevent script from fetching the translations until Tamara say so, is how I understand).

Tamara is this correct ?

It absolutely is. The translations will stay in Crowdin for the time being until we know what to do with them in the future, if going ahead and display them again or removing them completely.

However, if this is too much work, let me know and I will do a backup of the translations and then remove the languages directly from Crowdin.

comment:11 Changed 2 years ago by juliandoucette

  • Keywords goodfirstbug added
  • Priority changed from Unknown to P3
  • Ready set

comment:12 Changed 2 years ago by ire

  • Owner set to ire

comment:13 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:14 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4712 - [adblockbrowser.org - Remove Hindi and Bengali from the website and all traces of these languages]

comment:15 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:16 Changed 2 years ago by ire

Leaving this note from @saroyanm during code review:

The only problem I see with this is that the language specific links will be
broken, so we do not have a redirection when a adblockbrowser.org/$lang$/url is
being requested, but considering the fact that this pages have a very few visits
I think we good to go.

Note: See TracTickets for help on using tickets.