Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#4715 closed defect (fixed)

Update metadata to include antiadblockInit.js from adblockplusui instead of adblockpluscore

Reported by: wspee Assignee: wspee
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar Blocked By: #3672, #4659
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29376774/

Description (last modified by sebastian)

Background

#4762 and #4136 updated the adblockpluscore and adblockplusui dependency respectively, along other changes, moving antiadblockInit.js from adblockpluscore to adblockplusui (#3672). This change, however, isn't reflected in metadata.common yet, causing the build to fail.

Note that this issue was originally about updating the dependencies and performing the required downstream changes in one go. But unfortunately, the adblockpluscore dependency got already updated independently by #4762 without the necessary adaptions.

What to change

Update metadata.common to include antiadblockInit.js from adblockplusui instead from adblockpluscore.

Change History (12)

comment:1 Changed 3 years ago by wspee

  • Blocked By 4569 added
  • Priority changed from P2 to Unknown

comment:2 Changed 3 years ago by wspee

  • Cc sebastian kzar added

comment:3 Changed 3 years ago by wspee

  • Blocked By 4659 added; 4569 removed

comment:4 Changed 3 years ago by wspee

  • Description modified (diff)

comment:5 Changed 2 years ago by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by wspee

  • Type changed from defect to change

comment:8 Changed 2 years ago by wspee

  • Milestone set to Adblock-Plus-1.13-for-Chrome-Opera

comment:9 Changed 2 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 2 years ago by wspee

  • Description modified (diff)
  • Summary changed from Update adblockpluscore and adblockplusui dependency to TBA to Update metadata to include antiadblockInit.js from adblockplusui instead of adblockpluscore

comment:11 Changed 2 years ago by sebastian

  • Description modified (diff)
  • Type changed from change to defect

comment:12 Changed 2 years ago by sebastian

  • Description modified (diff)
Note: See TracTickets for help on using tickets.