Opened 2 years ago

Closed 2 years ago

#4726 closed change (fixed)

Add tests for the element hiding emulation content script

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Core Keywords:
Cc: trev Blocked By:
Blocking: #3143 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29367181/

Description

Background

We currently don't have automated tests for the element hiding emulation content script (chrome/content/elemHideEmulation.js), that makes it difficult to change.

What to change

  1. Add a new class of tests that run in a browser environment. It should be possible to invoke them separately from the existing nodeunit tests.
  2. Add tests for the element hiding emulation content script.

Change History (2)

comment:1 Changed 2 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by fhd

  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed

Landed: https://hg.adblockplus.org/adblockpluscore/rev/d575f050617e

The commit unfortunately references the wrong issue, #4276.

Note: See TracTickets for help on using tickets.