Opened 3 years ago

Closed 3 years ago

#4728 closed change (fixed)

Remove hard-coded references from statsmaster sitescripts.ini template

Reported by: matze Assignee: matze
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: ferris, paco Blocked By:
Blocking: #3576 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29367252/

Description

In #3638 and #3639 we refactored our code-base to use a central mechanism for applying resources specific to other hosts within the current environment. This included updating the modules/statsmaster/templates/sitescripts.ini.erb template so filter-servers are not hard-coded any more for subscription and notification analysis (see https://hg.adblockplus.org/infrastructure/rev/818dc7bb93ac for more information). That template contains some other hard-coded host references though, which should get refactored in the same fashion.

What To Do =

Replace mirror_download$i=download ... and mirror_update$i=update ... lines in modules/statsmaster/templates/sitescripts.ini.erb with sitescripts::configfragment resources in modules/adblockplus/manifests/hosts/statsmaster.pp, analogous to the patch-set linked above.

Change History (4)

comment:1 Changed 3 years ago by matze

  • Owner set to matze

comment:2 Changed 3 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.