Opened 9 months ago

Last modified 9 months ago

#4733 new change

Refactor nginx module

Reported by: paco Assignee:
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: matze, ferris Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29370627/

Description

Background

The current module mixes both configuration specifics and installation of the package, this leads to cyclic dependencies, for instance, one has to include the ssh module in nginx in order to have the latest updates of the ssl packages.

What to change

Remove the configuration from the nginx module and use an adblockplus::web (or something) defined type so the configuration specifics can be done in a different module.

Change History (3)

comment:1 Changed 9 months ago by matze

  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 9 months ago by paco

  • Review URL(s) modified (diff)

comment:3 Changed 9 months ago by abpbot

Note: See TracTickets for help on using tickets.