Opened 10 months ago

Closed 3 months ago

Last modified 6 weeks ago

#4738 closed change (fixed)

[UI] Redesign website view

Reported by: mario Assignee:
Priority: P2 Milestone: Adblock-Browser-for-iOS-2.0.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: Blocked By:
Blocking: #4706 Platform: Adblock Browser for iOS
Ready: no Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by mario)

Background

This issue is part of ABB's redesign as described under #4706.
Existing logic/UI which is not covered within this issue stays in place as it is.

What to change

Logic

  • If the website can be navigated back, mark the back-icon in the bottom bar as active
  • If the website can be navigated forward, mark the forward-icon in the bottom bar as active
  • If the website can not be navigated back, mark the back-icon in the bottom bar as inactive
  • If the website can not be navigated forward, mark the forward-icon in the bottom bar as inactive

Attachments

Style Guides

Assets

Attachments (5)

Adblock Browser Assets.2.zip (235.1 KB) - added by mario 10 months ago.
Adblock Browser Assets.zip (235.1 KB) - added by mario 10 months ago.
SavedBookmarks.PNG (69.5 KB) - added by traynard 3 months ago.
Image 1: Bookmarks currently saved in ABB (after removal of youtube)
BookmarkStar.PNG (848.8 KB) - added by traynard 3 months ago.
Image 2: The website still shows the bookmark star highlighted
RemoveBookmark.PNG (423.5 KB) - added by traynard 3 months ago.
Image 3: Even though this site is not bookmarked, my option is "Remove Bookmark"

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 months ago by mario

  • Description modified (diff)

comment:2 Changed 10 months ago by mario

  • Description modified (diff)

Changed 10 months ago by mario

Changed 10 months ago by mario

comment:3 Changed 9 months ago by mario

  • Priority changed from Unknown to P2

comment:4 Changed 4 months ago by jand

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 3 months ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next

Changed 3 months ago by traynard

Image 1: Bookmarks currently saved in ABB (after removal of youtube)

Changed 3 months ago by traynard

Image 2: The website still shows the bookmark star highlighted

Changed 3 months ago by traynard

Image 3: Even though this site is not bookmarked, my option is "Remove Bookmark"

comment:6 Changed 3 months ago by traynard

  • Resolution fixed deleted
  • Status changed from closed to reopened

When deleting a bookmark, ABB still remembers it and renders it on the website view.

Steps to Reproduce:
-Bookmark a website (youtube.com used in attached examples)
-Remove the bookmarked site
-Open a new tab and navigate to the site
Notice the bookmark star is highlighted and in the hamburger menu, it shows "Remove Bookmark"

Looks like the bookmark is being cached.

comment:7 Changed 3 months ago by jand

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:8 Changed 6 weeks ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.