#4738 closed change (fixed)
[UI] Redesign website view
| Reported by: | mario | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-iOS-2.0.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #4706 | Platform: | Adblock Browser for iOS |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Background
This issue is part of ABB's redesign as described under #4706.
Existing logic/UI which is not covered within this issue stays in place as it is.
What to change
Logic
- If the website can be navigated back, mark the back-icon in the bottom bar as active
- If the website can be navigated forward, mark the forward-icon in the bottom bar as active
- If the website can not be navigated back, mark the back-icon in the bottom bar as inactive
- If the website can not be navigated forward, mark the forward-icon in the bottom bar as inactive
Attachments
Style Guides
Assets
Attachments (5)
Change History (13)
comment:1 Changed 3 years ago by mario
- Description modified (diff)
comment:2 Changed 3 years ago by mario
- Description modified (diff)
Changed 3 years ago by mario
Changed 3 years ago by mario
comment:3 Changed 3 years ago by mario
- Priority changed from Unknown to P2
comment:4 Changed 3 years ago by jand
- Resolution set to fixed
- Status changed from new to closed
comment:5 Changed 3 years ago by mario
- Milestone set to Adblock-Browser-for-iOS-next
Changed 3 years ago by traynard
Changed 3 years ago by traynard
Image 3: Even though this site is not bookmarked, my option is "Remove Bookmark"
comment:6 Changed 3 years ago by traynard
- Resolution fixed deleted
- Status changed from closed to reopened
When deleting a bookmark, ABB still remembers it and renders it on the website view.
Steps to Reproduce:
-Bookmark a website (youtube.com used in attached examples)
-Remove the bookmarked site
-Open a new tab and navigate to the site
Notice the bookmark star is highlighted and in the hamburger menu, it shows "Remove Bookmark"
Looks like the bookmark is being cached.
comment:7 Changed 3 years ago by jand
- Resolution set to fixed
- Status changed from reopened to closed
comment:8 Changed 3 years ago by traynard
- Verified working set
Note: See
TracTickets for help on using
tickets.
Image 1: Bookmarks currently saved in ABB (after removal of youtube)