Opened 12 months ago

Closed 4 months ago

Last modified 3 months ago

#4741 closed change (fixed)

[UI] Redesign bookmark screen

Reported by: mario Assignee:
Priority: P2 Milestone: Adblock-Browser-for-iOS-2.0.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: mario Blocked By:
Blocking: #4706 Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by mario)

Background

This issue is part of ABB's redesign as described under #4706.
Logic/UI which is not covered within this issue stays in place as it is.

What to change

Apply the new design to ABB's bookmarks as shown in this mockup and this guide
Apply the new design to ABB's modify bookmarks screen as shown in this mockup and this guide

Transitions

  • When the bookmark screen is opened, slide it in from the bottom using iOS' default transition.
  • When the bookmark modify screen is opened, slide it in from the bottom using iOS' default transition.

Logic

  • If the bookmarks screen or modify bookmarks screen is shown:
    • Mark the back icon in the bottom bar inactive
    • Mark the forward icon in the bottom bar inactive
    • Mark the tabs icon in the bottom bar inactive
    • Mark the ghost mode icon in the bottom bar inactive
    • Mark the bookmark icon active and highlight it as shown in this mockup

Copy

  • Headline: Bookmarked Pages

Attachments

Style Guides

Assets

Mockups (as shown in description)

Attachments (5)

05 - Bookmarked Pages.png (75.9 KB) - added by mario 12 months ago.
05b - Bookmarked Pages - Edit Bookmark.png (57.2 KB) - added by mario 12 months ago.
05a - Bookmarked Pages - Edit.png (80.6 KB) - added by mario 12 months ago.
Adblock Browser Assets.zip (235.1 KB) - added by mario 12 months ago.
DeleteBookmark.mov (10.6 MB) - added by traynard 4 months ago.
Video of deleting bookmark

Download all attachments as: .zip

Change History (17)

Changed 12 months ago by mario

Changed 12 months ago by mario

comment:1 Changed 12 months ago by mario

  • Description modified (diff)

Changed 12 months ago by mario

comment:2 Changed 12 months ago by lisabielik

lgtm

comment:3 Changed 11 months ago by mario

  • Priority changed from Unknown to P2

comment:4 Changed 9 months ago by mario

  • Ready set

comment:5 Changed 6 months ago by jand

  • Status changed from new to reviewing

comment:6 Changed 5 months ago by jand

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 5 months ago by traynard

  • Cc mario added
  • Resolution fixed deleted
  • Status changed from closed to reopened
  1. Opening a bookmarked website does not return to website view. When tapping a bookmark, the page does not load. Additionally, once you try and open up a bookmarked website, there is no way to exit the Bookmarked Pages window. Users are forced to close ABB and re-open it in order to regain access to ABB.

-Open Bookmarked Pages screen
-Tap on a bookmarked page
-Click the favorite button at the bottom (nothing happens)
-Click the tabs icon (icon turns red, tabs do not open)

Expected Results: Clicking on a bookmarked page should collapse the bookmark screen and load the selected page. Tapping on tabs from the bookmarked pages screen should either be disabled, or collapse the bookmarked pages screen and open the tabs screen.


  1. Editing the order of bookmarks (Favorites > Edit > Rearrange order) and hitting "done" crashes the browser completely.

-Open bookmarked pages screen
-Tap Edit link at the top right
-Re-arrange the order of the bookmarks
-Tap the Done link at the top right
Browser crashes

Note: on iOS 11 ABB has to be fully uninstalled to regain access to the app. After the crash on iOS 11, when you re-launch the app you can't interact with ABB at all. The app is fully frozen forcing users to uninstall/reinstall

Last edited 5 months ago by traynard (previous) (diff)

comment:8 Changed 5 months ago by traynard

  • Milestone set to Adblock-Browser-for-iOS-next

comment:9 Changed 4 months ago by jand

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:10 Changed 4 months ago by traynard

  • Resolution fixed deleted
  • Status changed from closed to reopened

Issue #1 from my comment above still exists.

Additionally, when deleting a bookmark by selecting "Delete Bookmark" in edit mode after clicking on the specific bookmark deletes the data from within the bookmark, however the UI still displays the bookmark. This works fine when tapping the "-" to delete the bookmark. Please view attached video for example.

Last edited 4 months ago by traynard (previous) (diff)

Changed 4 months ago by traynard

Video of deleting bookmark

comment:11 Changed 4 months ago by jand

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:12 Changed 3 months ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.