Opened 3 years ago

Closed 2 years ago

#4749 closed defect (fixed)

eyeo.com Header covers content when printed

Reported by: juliandoucette Assignee:
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: jnink, saroyanm, greiner, jeen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by saroyanm)

Environment

  • Firefox v50
  • Chrome v54

How to reproduce

Try steps below in Firefox and Chrome

Observed behaviour

  • In Firefox the header icon is covering the navigation links, as show in current attachment and Chrome has "Join us" button even other navigation menus are not visible

Expected behaviour

  • Print version of the eyeo page should only contain eyeo logo(No other navigation/header item) from header.
  • eyeo logo should be repeated on all pages.

Attachments (2)

Privacy-chrome.pdf (84.2 KB) - added by saroyanm 3 years ago.
mozilla.pdf (66.9 KB) - added by saroyanm 3 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 3 years ago by saroyanm

  • Priority changed from P2 to P3

Changed to P3, because we have more prio tasks in the list.

comment:2 Changed 3 years ago by saroyanm

  • Description modified (diff)

Changed 3 years ago by saroyanm

Changed 3 years ago by saroyanm

comment:3 Changed 3 years ago by saroyanm

  • Description modified (diff)

comment:4 Changed 3 years ago by saroyanm

  • Description modified (diff)

comment:5 Changed 3 years ago by saroyanm

  • Description modified (diff)

comment:6 follow-up: Changed 3 years ago by greiner

  • Cc greiner added

The phrase "should behave the same way as in Chrome" is ambiguous. Is the header supposed to be at the start of every page (as it is in Chrome right now) or would it be sufficient to have the header only on the first page?

Furthermore certain elements within the header might still be overlaying each other so is this also supposed to be fixed as part of this ticket?

comment:7 in reply to: ↑ 6 Changed 3 years ago by saroyanm

  • Cc jeen added

Replying to greiner:

The phrase "should behave the same way as in Chrome" is ambiguous.

Initial intention of the ticket was to make Firefox Print view behave consistent with Chrome, which looks less intrusive.

Is the header supposed to be at the start of every page (as it is in Chrome right now) or would it be sufficient to have the header only on the first page?
Furthermore certain elements within the header might still be overlaying each other so is this also supposed to be fixed as part of this ticket?

I do agree with you that the ticket needs to be polished. I'll be in favor of having just a logo, without any further element.
@Jeen: Probably it's your shot:

  • Can we remove whole header and keep only logo ?
  • Should we keep repeating header on each page, or only on the first page ?

comment:8 Changed 3 years ago by jeen

  • I am in favour of removing the whole header and keeping only the logo.
  • Repeat the logo on all pages.
  • Remove the "Join us we're hiring" button which still appears in Chrome.

comment:9 Changed 3 years ago by saroyanm

  • Description modified (diff)

Thanks Jeen and Thomas, updated.

comment:10 Changed 3 years ago by saroyanm

  • Description modified (diff)
  • Keywords goodfirstbug added

comment:11 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4749 - Removed header artifacts from print

comment:12 Changed 2 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from new to closed

I will consider "Repeat the logo on all pages." a separate (less important) issue.

Note: See TracTickets for help on using tickets.