Opened 6 years ago

Closed 2 years ago

#475 closed change (rejected)

Use new OS.File.read()

Reported by: David Rajchenbach-Teller Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: smultron45@…, trev, arthur Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://github.com/adblockplus/adblockplus/pull/3

Description

In ABP for Firefox, readFromFile could be simplified.
Recent versions of Gecko offer

 OS.File.read(path, { encoding: "utf-8" });

which performs the read and decoding entirely off the main thread.

I'll try and work on a patch in the next few days if I have a little time.

Change History (6)

comment:1 Changed 6 years ago by mapx

  • Cc smultron45@… added

comment:2 Changed 6 years ago by trev

  • Cc trev added
  • Priority changed from Unknown to P4
  • Ready set
  • Review URL(s) modified (diff)

I'm somewhat undecided on the priority here. The documentation on OS.File.read() hasn't been updated yet but it seems that the relevant bug here is https://bugzilla.mozilla.org/show_bug.cgi?id=961665 which means that this feature was introduced in Firefox 30. So we can either wait until Firefox 31 becomes the new ESR release (October) or we can implement this in a backwards compatible way (this might eat away most of the simplification achieved).

comment:3 Changed 6 years ago by arthur

  • Cc Trevor arthur added; trev removed

comment:4 Changed 6 years ago by arthur

  • Cc trev added; Trevor removed

comment:5 Changed 5 years ago by philll

  • Platform set to Firefox

comment:6 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.