Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4762 closed change (fixed)

Add relentless notification type

Reported by: wspee Assignee: wspee
Priority: P1 Milestone:
Module: Core Keywords:
Cc: fhd, sebastian, philll, trev, greiner Blocked By:
Blocking: #4764 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29370562/

Description

Background

For legal reasons we want to inform our users, on certain websites, that "false positives" (blocked content that is not an ad) can occur.

What to change

To allow that add a new notification type "relentless" that:

  • Shows a desktop notification that contains only text (like a normal notification)
  • Can be closed but not deactivated
  • Shows up in regular intervals via an attribute named "interval" that defines the interval in milliseconds

Change History (12)

comment:1 Changed 3 years ago by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by fhd

  • Cc fhd added
  • Priority changed from Unknown to P1

comment:3 Changed 3 years ago by wspee

  • Blocking 4764 added

comment:4 Changed 3 years ago by wspee

  • Review URL(s) modified (diff)

See #4764

comment:5 follow-up: Changed 3 years ago by sebastian

  • Cc sebastian philll trev added
  • Ready unset

The issue doesn't specify when such a notification should be shown, I suppose we would want to show that notification when the user visits one out of a list of specific websites/domains?

Is it already established anyway that we want to that? When we discussed that in one of our previous team meetings this feature seemed to be quite controversial. Personally, I'd also rather like to avoid this, but rather have a disclaimer on the first run page for example, if possible.

Also please don't mark issues as Ready yourself, this is up to the module owner. Wladimir is the module owner for Core.

comment:6 Changed 3 years ago by fhd

Is it already established anyway that we want to that? When we discussed that in one of our previous team meetings this feature seemed to be quite controversial. Personally, I'd also rather like to avoid this, but rather have a disclaimer on the first run page for example, if possible.

Yes, we need this for legal reasons, and will not use it for anything else. Not going into more detail so we can keep the issue public.

comment:7 in reply to: ↑ 5 ; follow-up: Changed 3 years ago by wspee

Replying to sebastian:

The issue doesn't specify when such a notification should be shown, I suppose we would want to show that notification when the user visits one out of a list of specific websites/domains?

Yes, there will be a separate issue to add the required notifications as a server side notification but I haven't created it yet because I don't have the required texts.

Also please don't mark issues as Ready yourself, this is up to the module owner. Wladimir is the module owner for Core.

Ok sorry, I looked into the TracGuide because I wasn't sure who is supposed to set the Ready flag but this isn't specified so I set it myself.

comment:8 in reply to: ↑ 7 Changed 3 years ago by sebastian

Replying to wspee:

Ok sorry, I looked into the TracGuide because I wasn't sure who is supposed to set the Ready flag but this isn't specified so I set it myself.

The responsibilities of module owners are documented here. But it makes sense to be more explicit in the TracGuide as well, I just updated it.

comment:9 Changed 3 years ago by greiner

  • Cc greiner added

comment:10 Changed 3 years ago by abpbot

comment:11 Changed 3 years ago by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 3 years ago by abpbot

Note: See TracTickets for help on using tickets.