Opened on 01/02/2017 at 02:06:10 PM

Closed on 07/05/2017 at 08:51:01 AM

#4765 closed change (fixed)

Change minimum compatible versions

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: fhd Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by diegocarloslima)


Since we're using our own versioning in Adblock Browser, we need to change the minimum compatible version preference for the app and the platform. That way, our ABP extension, which has maxVersion of 1.0 for adblockbrowser, doesn't get disabled.

What to change

Change both preferences extensions.minCompatibleAppVersion and extensions.minCompatiblePlatformVersion to 1.0.

Hints for Testers

This can be tested together with #2520 . With compatibility check enabled, it means that it will check if the ABP plugin is compatible with the ABB MOZ_APP_ID, which is55aba3ac-94d3-41a8-9e25-5c21fe874539 (ABP defines the compatible IDs here) and with the ABB app version, which is 1.1.1 (ABP defines the compatible versions here. So basically this issue can be verified by the fact that the ABP plugin is working after re-enabling compatibility check.

Attachments (0)

Change History (10)

comment:1 Changed on 01/02/2017 at 03:22:26 PM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 follow-up: Changed on 01/02/2017 at 04:42:47 PM by fhd

Looks like a regression from #2520 to me - wasn't this tested?

comment:3 Changed on 01/02/2017 at 04:43:10 PM by fhd

  • Cc fhd added

comment:4 in reply to: ↑ 2 Changed on 01/02/2017 at 05:01:42 PM by diegocarloslima

Replying to fhd:

Looks like a regression from #2520 to me - wasn't this tested?

Yes, it's a regression. I underestimated #2520 since the changes were pretty straightforward, so I just performed an android build instead of a full build to test it. That way, I couldn't detect this issue beforehand

comment:5 Changed on 01/02/2017 at 05:02:43 PM by fhd


comment:6 Changed on 01/02/2017 at 09:51:23 PM by abpbot

A commit referencing this issue has landed:
Issue 4765 - Change minimum compatible versions

comment:7 Changed on 01/02/2017 at 10:46:50 PM by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 06/20/2017 at 09:30:27 AM by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer

Is there any way for me to effectively check this? Is it possible for some hints for testers?

comment:9 Changed on 06/30/2017 at 08:09:47 PM by diegocarloslima

  • Description modified (diff)

comment:10 Changed on 07/05/2017 at 08:51:01 AM by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Verified working set
  • The ABP plugin works after re-enabling the compatibility check.

Galaxy S7
Android 7.0

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Note: See TracTickets for help on using tickets.