Changes between Version 18 and Version 20 of Ticket #4766


Ignore:
Timestamp:
02/06/2017 06:55:52 PM (10 months ago)
Author:
mario
Comment:

Removed the first notification from the scope of this issue in order to align the notification logic with the crash report logic: Only prompt the user to send a report if the default value "Always ask" is configured in the user's crash/error reporting settings.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4766 – Description

    v18 v20  
    22The new functionality of reporting non critical errors #4672 enabled proper reporting of one specific kind of *critical* errors, and that is a failure to initialize on app startup. The app actually should not continue operating - it's missing vital parts. 
    33 
    4 However, #4672 wasn't originally intended to report critical errors but only non-crashing errors. Due to the fact, that we happen to be able to catch said critical error on runtime, we need to display a more specific notification and kill the application programatically in this instance. 
     4However, #4672 wasn't originally intended to report critical errors but only non-crashing errors. Due to the fact, that we happen to be able to catch said critical error on runtime, we need to display a more specific notification/error and ask the user to restart ABB. 
    55 
    66=== What to change === 
     
    88 
    991. If the option "Always Send" (Settings -> Crash Reporting) is selected 
    10  a. Display a notification with the following content 
    11   i. Headline: {{{Adblock Browser}}} 
    12   ii. Text: {{{Unable to start browser. This issue has been reported to developers.}}} 
    13   iii. Button 1: {{{Close}}} 
    14  b. If "Button 1" is clicked, send a crash event and close the notification 
     10 a. Display no notification 
    1511 
    16122. If the option "Ask Me" (Settings -> Crash Reporting) is selected 
     
    2622 a. Display no notification 
    2723 
    28 After the notification has been closed (or in case it wasn't shown as per point 3.), display [https://issues.adblockplus.org/attachment/ticket/4766/216987692.png this error message] on the splash screen as specified in [https://projects.invisionapp.com/d/main#/console/9140728/216987692/inspect this style guide]. Text: 
     24After the notification has been closed (or in case it wasn't shown as per point 1. and 3.), display [https://issues.adblockplus.org/attachment/ticket/4766/216987692.png this error message] on the splash screen as specified in [https://projects.invisionapp.com/d/main#/console/9140728/216987692/inspect this style guide]. Text: 
    2925 - Headline: {{{Uh-oh!}}} 
    3026 - 2nd headline: {{{Something went wrong.}}}