Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#4767 closed change (fixed)

Improve error reporting in update_update_manifests

Reported by: ferris Assignee: poz2k4444
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: trev, jsonesen, kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29370859/patch/29370862/29370863

Description

Environment

update1

How to reproduce

Theory: Run the update_update_manifests sitescript while overriding the remote URL https://services.addons.mozilla.org/en-US/firefox/api/1/addon/adblock-plus to respond with an error

Observed behaviour

Receiving these cron error mails a few times every month:

Title: Cron <sitescripts@update1> /usr/local/bin/update_update_manifests

Traceback (most recent call last):
  File "/opt/sitescripts/sitescripts/extensions/utils.py", line 319, in getDownloadLinks
    (downloadURL, version) = _getDownloadLink(repo)
  File "/opt/sitescripts/sitescripts/extensions/utils.py", line 295, in _getDownloadLink
    return _getMozillaDownloadLink(repo.galleryID)
  File "/opt/sitescripts/sitescripts/extensions/utils.py", line 263, in _getMozillaDownloadLink
    document = dom.parse(_urlopen(url))
  File "/usr/lib/python2.7/xml/dom/minidom.py", line 1920, in parse
    return expatbuilder.parse(file)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 928, in parse
    result = builder.parseFile(file)
  File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 207, in parseFile
    parser.Parse(buffer, 0)
ExpatError: mismatched tag: line 6, column 2

Expected behaviour

More information on which URL responded with what error and a suggested action to take (i.e. make sure that the remote service is up, still exists, etc).

Change History (6)

comment:1 Changed 11 months ago by paco

  • Review URL(s) modified (diff)

comment:2 Changed 11 months ago by jsonesen

  • Cc jsonesen kvas added

comment:3 Changed 11 months ago by jsonesen

Hey guys,

Is it alright if you CC myself, Vasily, or Sebastian when making tickets in relation to the sitescripts module? For reference you can see who should be CC'd and added to reviews in the modules section of the adblockplus.org website. This is helpful so that we can discuss the implementation and document it here prior to actually making the review or merging code. This way reviewing is streamlined and does not have to include as much of the implementation discussion.

comment:4 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 4767 - Improve error reporting in update_update_manifests...

comment:5 Changed 10 months ago by poz2k4444

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 10 months ago by sebastian

  • Owner changed from ferris to poz2k4444

Please assign issues to yourself when you are working on them.

Note: See TracTickets for help on using tickets.