Opened on 01/03/2017 at 12:36:36 PM
Closed on 01/16/2017 at 04:33:52 PM
Last modified on 01/17/2017 at 09:26:22 AM
#4767 closed change (fixed)
Improve error reporting in update_update_manifests
Reported by: | ferris | Assignee: | poz2k4444 |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Sitescripts | Keywords: | |
Cc: | trev, jsonesen, kvas | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29370859/patch/29370862/29370863 |
Description
Environment
update1
How to reproduce
Theory: Run the update_update_manifests sitescript while overriding the remote URL https://services.addons.mozilla.org/en-US/firefox/api/1/addon/adblock-plus to respond with an error
Observed behaviour
Receiving these cron error mails a few times every month:
Title: Cron <sitescripts@update1> /usr/local/bin/update_update_manifests
Traceback (most recent call last): File "/opt/sitescripts/sitescripts/extensions/utils.py", line 319, in getDownloadLinks (downloadURL, version) = _getDownloadLink(repo) File "/opt/sitescripts/sitescripts/extensions/utils.py", line 295, in _getDownloadLink return _getMozillaDownloadLink(repo.galleryID) File "/opt/sitescripts/sitescripts/extensions/utils.py", line 263, in _getMozillaDownloadLink document = dom.parse(_urlopen(url)) File "/usr/lib/python2.7/xml/dom/minidom.py", line 1920, in parse return expatbuilder.parse(file) File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 928, in parse result = builder.parseFile(file) File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 207, in parseFile parser.Parse(buffer, 0) ExpatError: mismatched tag: line 6, column 2
Expected behaviour
More information on which URL responded with what error and a suggested action to take (i.e. make sure that the remote service is up, still exists, etc).
Attachments (0)
Change History (6)
comment:2 Changed on 01/09/2017 at 08:23:57 AM by jsonesen
- Cc jsonesen kvas added
comment:3 Changed on 01/09/2017 at 08:30:12 AM by jsonesen
comment:4 Changed on 01/16/2017 at 03:49:37 PM by abpbot
A commit referencing this issue has landed:
Issue 4767 - Improve error reporting in update_update_manifests...
comment:5 Changed on 01/16/2017 at 04:33:52 PM by poz2k4444
- Resolution set to fixed
- Status changed from new to closed
comment:6 Changed on 01/17/2017 at 09:26:22 AM by sebastian
- Owner changed from ferris to poz2k4444
Please assign issues to yourself when you are working on them.
Hey guys,
Is it alright if you CC myself, Vasily, or Sebastian when making tickets in relation to the sitescripts module? For reference you can see who should be CC'd and added to reviews in the modules section of the adblockplus.org website. This is helpful so that we can discuss the implementation and document it here prior to actually making the review or merging code. This way reviewing is streamlined and does not have to include as much of the implementation discussion.