Changes between Version 5 and Version 9 of Ticket #4769


Ignore:
Timestamp:
05/17/2017 06:52:36 AM (3 years ago)
Author:
mario
Comment:

As discussed, I've declared the method of URL verification in more detail in this ticket and added a follow up to handle better URL verification separately: #5254. Thus closing this issue.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4769

    • Property Tester changed from Unknown to Scheer
  • Ticket #4769 – Description

    v5 v9  
    1515 - If one or more websites are whitelisted the {{{Whitelisted websites}}} [https://issues.adblockplus.org/attachment/ticket/4769/ABP_SBrowser_Whitelist_01.png settings screen] lists the whitelisted websites. 
    1616 - If {{{Add a website to the whitelist}}} is tapped, the {{{Whitelist website}}} [https://issues.adblockplus.org/attachment/ticket/4769/ABP_SBrowser_Whitelist_02.png modal dialog] is shown. 
    17   - if an invalid URL is entered in the {{{Whitelist website}}} [https://issues.adblockplus.org/attachment/ticket/4769/ABP_SBrowser_Whitelist_02.png modal dialog] or if the URL field is empty, disable the OK button as shown [https://issues.adblockplus.org/attachment/ticket/4769/ABP_SBrowser_Whitelist_02.png in this screenshot]. 
     17  - if an invalid URL* is entered in the {{{Whitelist website}}} [https://issues.adblockplus.org/attachment/ticket/4769/ABP_SBrowser_Whitelist_02.png modal dialog] or if the URL field is empty, disable the OK button as shown [https://issues.adblockplus.org/attachment/ticket/4769/ABP_SBrowser_Whitelist_02.png in this screenshot]. 
    1818  - if a valid URL is entered in the {{{Whitelist website}}} [https://issues.adblockplus.org/attachment/ticket/4769/ABP_SBrowser_Whitelist_02.png modal dialog], enable the OK button. 
    1919  - If the {{{CANCEL}}} button is tapped, close the modal dialog and perform no action. 
    2020  - If the {{{OK}}} button is tapped, verify the URL, close the modal dialog and add the entered website to the list of whitelisted websites as shown in [https://issues.adblockplus.org/attachment/ticket/4769/ABP_SBrowser_Whitelist_01.png this screenshot]. 
    2121  - If a website is whitelisted, no ads are blocked on this website. 
     22 
     23*Invalid URL: invalid as per [https://developer.android.com/reference/android/util/Patterns.html#WEB_URL ​Patterns.WEB_URL.matcher] and [https://www.ietf.org/rfc/rfc3987.txt RFC 3987]. URL's aren't tested for existence. TLD's aren't tested for validity.