Opened 3 years ago

Closed 12 months ago

#4773 closed change (rejected)

Revert temporary fix for removing unsupported filters

Reported by: diegocarloslima Assignee:
Priority: P5 Milestone:
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by diegocarloslima)

Background

Once Samsung Internet handles filter edge cases without crashing, we should revert the temporary fix for removing unsupported filters.

What to change

Revert changes introduced in #4772

Change History (5)

comment:1 Changed 3 years ago by diegocarloslima

  • Description modified (diff)
  • Summary changed from Remove temporary fix for removing unsupported filters to Revert temporary fix for removing unsupported filters

comment:2 Changed 3 years ago by diegocarloslima

  • Priority changed from Unknown to P5

comment:3 Changed 2 years ago by jwangenheim

I initialized Easylist Russia without removing any filters and had no problems so far. No crashes or ANRs. Maybe scott or rick can double check so we can remove the fix for the next release.

comment:4 Changed 2 years ago by diegocarloslima

Before reverting this change, we need to check with Samsung on what version they fixed those edge cases and what is the % of users that still uses an older version of Samsung Internet, which doesn't contain the fix. The % should be really low in order to avoid having users getting crashes again by downloading/updating ABP for Samsung Internet while having an old version of Samsung Internet.

Last edited 2 years ago by diegocarloslima (previous) (diff)

comment:5 Changed 12 months ago by jchee

  • Resolution set to rejected
  • Status changed from new to closed

Closing ticket as it has been moved to Gitlab:
https://gitlab.com/eyeo/adblockplus/adblockplussbrowser/issues/12

Note: See TracTickets for help on using tickets.