Opened on 01/04/2017 at 06:05:33 PM

Closed on 12/20/2018 at 04:34:12 AM

#4773 closed change (rejected)

Revert temporary fix for removing unsupported filters

Reported by: diegocarloslima Assignee:
Priority: P5 Milestone:
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by diegocarloslima)


Once Samsung Internet handles filter edge cases without crashing, we should revert the temporary fix for removing unsupported filters.

What to change

Revert changes introduced in #4772

Attachments (0)

Change History (5)

comment:1 Changed on 01/04/2017 at 06:07:12 PM by diegocarloslima

  • Description modified (diff)
  • Summary changed from Remove temporary fix for removing unsupported filters to Revert temporary fix for removing unsupported filters

comment:2 Changed on 05/23/2017 at 02:29:02 PM by diegocarloslima

  • Priority changed from Unknown to P5

comment:3 Changed on 08/25/2017 at 01:22:47 PM by jwangenheim

I initialized Easylist Russia without removing any filters and had no problems so far. No crashes or ANRs. Maybe scott or rick can double check so we can remove the fix for the next release.

comment:4 Changed on 08/25/2017 at 03:09:04 PM by diegocarloslima

Before reverting this change, we need to check with Samsung on what version they fixed those edge cases and what is the % of users that still uses an older version of Samsung Internet, which doesn't contain the fix. The % should be really low in order to avoid having users getting crashes again by downloading/updating ABP for Samsung Internet while having an old version of Samsung Internet.

Last edited on 08/25/2017 at 03:10:03 PM by diegocarloslima

comment:5 Changed on 12/20/2018 at 04:34:12 AM by jchee

  • Resolution set to rejected
  • Status changed from new to closed

Closing ticket as it has been moved to Gitlab:

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.