Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4783 closed change (fixed)

Switch message_responder.js to use the messaging API

Reported by: kzar Assignee: kzar
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: sebastian, greiner Blocked By:
Blocking: #4579, #4823 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29370996/
https://codereview.adblockplus.org/29370999/
https://codereview.adblockplus.org/29371585/

Description (last modified by kzar)

Background

messageResponder.js contains a rather monolithic message listener, still using the ext API which is planned to go away.

What to change

Break the message listener down into separate listeners which use the Port API. (See adblockpluschrome/lib/messaging.js.)

While at it we might as well update the file to use more modern JavaScript syntax like let instead of var, arrow functions and for of. We also might as well remove the code for Safari support which is no longer needed.

Change History (6)

comment:1 Changed 3 years ago by kzar

  • Description modified (diff)

comment:2 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)

comment:5 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 3 years ago by kzar

  • Blocking 4823 added
Note: See TracTickets for help on using tickets.