Opened 10 months ago

Last modified 10 months ago

#4786 reviewing change

Add application, applicationVersion, platform and platformVersion setter/getter to adblockplusadblockbrowserios

Reported by: mario Assignee: mario
Priority: P2 Milestone:
Module: Adblock-Browser-for-iOS Keywords:
Cc: Blocked By:
Blocking: #4785 Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://bitbucket.org/adblockplus/adblockplusadblockbrowserios/pull-requests/7/issue-4786-add-application-and-platform/diff

Description (last modified by mario)

Background

With #4785 we intend to forward missing variables for query string parameters to ABP in order to utilize them during filter lists/notification requests. In order to do so, we need to introduce a possibility to set/get those missing variables via the api.js of adblockplusadblockbrowserios

What to change

1. Add possibility to set/get parameters
Add a possibility to set and get query string parameters within the api.js of adblockplusadblockbrowserios for the following variables of ABP:

  • application
  • applicationVersion
  • platform
  • platformVersion

2. Clean up #3653
Undo the changes already introduced via this commit. (application has already been hardcoded via #3653. This was meant to be a temporary solution and thus needs to be removed as soon as the application getter has been introduced.)

Change History (4)

comment:1 Changed 10 months ago by mario

  • Summary changed from Add application, applicationVersion, platform and platformVersion setter/getter to adblockplusbrowserios to Add application, applicationVersion, platform and platformVersion setter/getter to adblockplusadblockbrowserios

comment:2 Changed 10 months ago by mario

  • Description modified (diff)

comment:3 Changed 10 months ago by mario

  • Owner set to mario
  • Priority changed from Unknown to P2
  • Ready set
  • Review URL(s) modified (diff)

comment:4 Changed 10 months ago by mario

  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.