Opened 3 years ago

Closed 22 months ago

#4791 closed change (fixed)

Add favicon to the whitelist functionality in the safari share dialog

Reported by: mario Assignee: ashephard
Priority: P3 Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By: #3184, #6073
Blocking: #6166 Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29603689/

Description (last modified by mario)

Background

#3184 introduces the possibility to whitelist websites via the Safari Share Dialog. In order to make the whitelist notification more accessible as well as to make it more compliant with the UI of the rest of the application we want to show the favicon of the Website.

What to change

As shown in this mockup and this style guide, show the favicon of the whitelisted website in the whitelist share dialog.

Attachments (1)

211951537.png (66.5 KB) - added by mario 3 years ago.

Download all attachments as: .zip

Change History (14)

Changed 3 years ago by mario

comment:1 Changed 3 years ago by mario

  • Description modified (diff)

comment:2 Changed 2 years ago by ashephard

  • Owner set to ashephard

Will tackle this once #3184 has landed.

comment:3 Changed 2 years ago by ashephard

Code and UI has been updated, but waiting on #3184 to be landed and closed before submitting.

comment:4 Changed 2 years ago by ashephard

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 2 years ago by ashephard

Opted to pause this ticket until the Safari Action Extension has been rewritten in Swift.

comment:6 Changed 2 years ago by ashephard

  • Status changed from reviewing to reopened

comment:7 Changed 2 years ago by ashephard

Will rewrite the favicon logic in Swift now that the Action Extension has been rewritten.

comment:8 Changed 2 years ago by ashephard

  • Review URL(s) modified (diff)

comment:9 Changed 2 years ago by ashephard

  • Review URL(s) modified (diff)

comment:10 Changed 2 years ago by ashephard

  • Status changed from reopened to reviewing

comment:11 Changed 2 years ago by ashephard

  • Blocked By 6073 added

comment:12 Changed 23 months ago by dzhang

  • Blocking 6166 added

comment:13 Changed 22 months ago by ashephard

  • Milestone set to Adblock-Plus-for-iOS-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.