Opened on 01/12/2017 at 10:54:58 AM

Closed on 01/13/2018 at 12:04:30 PM

#4791 closed change (fixed)

Add favicon to the whitelist functionality in the safari share dialog

Reported by: mario Assignee: ashephard
Priority: P3 Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By: #3184, #6073
Blocking: #6166 Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mario)


#3184 introduces the possibility to whitelist websites via the Safari Share Dialog. In order to make the whitelist notification more accessible as well as to make it more compliant with the UI of the rest of the application we want to show the favicon of the Website.

What to change

As shown in this mockup and this style guide, show the favicon of the whitelisted website in the whitelist share dialog.

Attachments (1)

211951537.png (66.5 KB) - added by mario on 01/12/2017 at 10:55:23 AM.

Download all attachments as: .zip

Change History (14)

Changed on 01/12/2017 at 10:55:23 AM by mario

comment:1 Changed on 01/12/2017 at 10:57:51 AM by mario

  • Description modified (diff)

comment:2 Changed on 08/23/2017 at 02:29:50 PM by ashephard

  • Owner set to ashephard

Will tackle this once #3184 has landed.

comment:3 Changed on 09/07/2017 at 04:08:21 PM by ashephard

Code and UI has been updated, but waiting on #3184 to be landed and closed before submitting.

comment:4 Changed on 09/13/2017 at 03:06:33 PM by ashephard

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 09/25/2017 at 01:43:30 PM by ashephard

Opted to pause this ticket until the Safari Action Extension has been rewritten in Swift.

comment:6 Changed on 10/09/2017 at 10:48:29 AM by ashephard

  • Status changed from reviewing to reopened

comment:7 Changed on 10/09/2017 at 10:50:01 AM by ashephard

Will rewrite the favicon logic in Swift now that the Action Extension has been rewritten.

comment:8 Changed on 10/20/2017 at 10:04:10 AM by ashephard

  • Review URL(s) modified (diff)

comment:9 Changed on 11/10/2017 at 01:07:21 PM by ashephard

  • Review URL(s) modified (diff)

comment:10 Changed on 11/13/2017 at 09:59:53 AM by ashephard

  • Status changed from reopened to reviewing

comment:11 Changed on 11/22/2017 at 11:03:01 AM by ashephard

  • Blocked By 6073 added

comment:12 Changed on 12/13/2017 at 06:02:22 PM by dzhang

  • Blocking 6166 added

comment:13 Changed on 01/13/2018 at 12:04:30 PM by ashephard

  • Milestone set to Adblock-Plus-for-iOS-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ashephard.
Note: See TracTickets for help on using tickets.