Changes between Version 3 and Version 10 of Ticket #4796


Ignore:
Timestamp:
04/13/2017 06:49:28 PM (3 years ago)
Author:
trev
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4796

    • Property Priority changed from P5 to P3
    • Property Ready unset
    • Property Cc hfiguiere added
  • Ticket #4796 – Description

    v3 v10  
    11=== Background === 
    2 As of #4726, we have automated browser tests in Core. We are using PhantomJS 2.1.7 for these, which is based on a version of WebKit that doesn't support ECMAScript 2015 features (such as `let`). 
     2As of #4726, we have automated browser tests in Core. We are using PhantomJS 2.1.7 for these, which is based on a version of WebKit that doesn't support ECMAScript 2015 features (such as `let`). With PhantomJS being unmaintained, we shouldn't expect updates. 
    33 
    44=== What to change === 
    5 - Use PhantomJS 2.5 for our tests once it is available. 
     5- Replace PhantomJS by headless Chromium (headless mode available starting with Chromium 59). 
     6- Have test runner download a platform-specific Chromium build from https://commondatastorage.googleapis.com/chromium-browser-snapshots/ (which revision?). 
     7- Chromium should be downloaded and unpacked under `test/chromium/chromium-{platform}-{revision}` - only if this directory doesn't exist yet. Having Chromium revision in directory name allows us to change to a different revision later. The `test/chromium` directory should be added to `.hgignore`/`.gitignore`. 
     8- Test runner should run tests by instrumenting this Chromium instance via [https://github.com/cyrus-and/chrome-remote-interface chrome-remote-interface package]. 
    69- Remove the following files from `adblockpluscore/.eslintignore` and update those files so that linting passes: `chrome/content/elemHideEmulation.js`, `lib/common.js` and `test/browser/elemHideEmulation.js`. 
    710- Remove the comments that mention this issue.