Changes between Version 10 and Version 14 of Ticket #4796


Ignore:
Timestamp:
04/26/2017 11:07:31 AM (2 years ago)
Author:
trev
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4796

    • Property Cc sergz added
    • Property Priority changed from P3 to P2
    • Property Keywords externaldependency removed
    • Property Ready set
    • Property Blocking changed from to 3143
  • Ticket #4796 – Description

    v10 v14  
    44=== What to change === 
    55- Replace PhantomJS by headless Chromium (headless mode available starting with Chromium 59). 
    6 - Have test runner download a platform-specific Chromium build from https://commondatastorage.googleapis.com/chromium-browser-snapshots/ (which revision?). 
     6- Have test runner download a platform-specific Chromium build from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html. 
     7- We need to know which snapshot revision to download. Headless landed in Chrome 59, and Chrome 59.0.3071.28 was [https://chromium.googlesource.com/chromium/src/+/8d0588f0524a1107cbb2c25d0b4dd404d9d89b1a branched off revision 464641]. There are no snapshots for this revision however, we need to use the closest one which is different depending on the platform: 
     8 * 464638 for [https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win/464638/ Windows] and [https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win_x64/464638/ Windows x64] 
     9 * 464640 for [https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Linux_x64/464640/ Linux x64] 
     10 * 464636 for [https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/464636/ Mac] 
    711- Chromium should be downloaded and unpacked under `test/chromium/chromium-{platform}-{revision}` - only if this directory doesn't exist yet. Having Chromium revision in directory name allows us to change to a different revision later. The `test/chromium` directory should be added to `.hgignore`/`.gitignore`. 
    812- Test runner should run tests by instrumenting this Chromium instance via [https://github.com/cyrus-and/chrome-remote-interface chrome-remote-interface package].