Opened on 01/16/2017 at 08:53:59 AM

Closed on 01/16/2017 at 01:52:27 PM

Last modified on 03/13/2017 at 08:33:51 AM

#4803 closed defect (fixed)

Punycode module broken when we stopped using JS Hydra

Reported by: kzar Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-1.13-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



When we stopped using JS Hydra #4552 we changed the way modules work. It turns out we didn't consider how the punycode module reassigns the exports variable.

How to reproduce

  1. Open the background console for Adblock Plus in Chrome.
  2. Type require("punycode");

Observed behaviour

An empty Object is returned.

Expected behaviour

A non-empty Object is returned.

Attachments (0)

Change History (6)

comment:1 Changed on 01/16/2017 at 08:59:44 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/16/2017 at 09:00:15 AM by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next

comment:3 Changed on 01/16/2017 at 09:01:11 AM by kzar

  • Ready set

comment:4 Changed on 01/16/2017 at 01:51:47 PM by abpbot

A commit referencing this issue has landed:
Issue 4803 - Fix punycode module exports

comment:5 Changed on 01/16/2017 at 01:52:27 PM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 03/13/2017 at 08:33:51 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Object is returned.

Chrome 49 / 56 / Windows 10
Chrome 56 / OS X 10.12
Chrome 56 / Ubuntu 16.04
Opera 37 / 41 / Windows 7
Safari 10 / OS X 10.12

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.