Opened 3 years ago

Closed 2 years ago

#4806 closed change (rejected)

Update buildtools dependency for Microsoft Edge bookmark

Reported by: oleksandr Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29372122/

Description (last modified by oleksandr)

Background

We have added improved support for Edge builds in #4719 and now we need to use that code in build process.

NOTE: In https://hg.adblockplus.org/adblockpluschrome/rev/5dc8547d6e49 I have referenced a non-existing buildtools version 84c599613ecb. This was since fixed in https://hg.adblockplus.org/adblockpluschrome/diff/1599db1fb473/dependencies where a correct version 4cea55c4bdc0 was referenced. This should update buildtools further to 1b8ddae7f0b3, however this was already done in https://hg.adblockplus.org/adblockpluschrome/rev/9d07dcf71051. This issue can be closed now.

What to change

Update buildtools reference in adblockpluschrome repository in edge bookmark to the latest version.

Change History (7)

comment:1 Changed 3 years ago by oleksandr

  • Component changed from Unknown to Platform
  • Platform changed from Unknown / Cross platform to Edge
  • Ready set

comment:2 Changed 3 years ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by kzar

You mentioned that the revision was already updated in a different commit, but that there was a mistake there. I think that should be mentioned in this issue description along with a link to the commit. IMO this is a defect issue fixing that regression rather than a standard change issue to update the dependency.

comment:4 Changed 2 years ago by kzar

What's the status of this issue Ollie?

comment:5 Changed 2 years ago by oleksandr

  • Description modified (diff)

comment:6 Changed 2 years ago by oleksandr

Update the description. This issue can be closed.

comment:7 Changed 2 years ago by kzar

  • Resolution set to rejected
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.